Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Support for more quantum chemistry operations #59

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Conversation

kshyatt-aws
Copy link
Member

Issue #, if available: #14

Description of changes: Updated version of #25 using the updated interface for gates

Testing done: Unit tests passed locally

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Fe-r-oz and others added 2 commits October 9, 2024 12:25
* [Feature]: Expanded support for quantum chemistry operations

* [Feature]: Expanded support for quantum chemistry operations: Improved tests for SingleExcitationPlus and SingleExcitationMinus

* [Feature]: Expanded support for quantum chemistry operations: Formatting

* [Feature]: Expanded support for quantum chemistry operations: Tests for DoubleExcitationPlus, DoubleExcitationMinus, FermionicSWAP

* [Feature]: Expanded support for quantum chemistry operations: Completing docstrings for all quantum chemistry gates

* [Feature]: Expanded support for quantum chemistry operations: Adding hrefs for qchem gates and minor cleanup

* [Feature]: Expanded support for quantum chemistry operations - fix documentation

* [Feature]: Expanded support for quantum chemistry operations - codereview

* [Feature]: Expanded support for quantum chemistry operations - fix doublexcitationplus and doubleexcitation minus

* code review suggestions

* Minor Formating changes, Polishing up everything

* Formating changes

* using ϕ instead of \varphi

* adding gate exponentiation and tests

* Polishing up gate exponentiation, and testing it

* using iszero check for gate exponentiation power == 0 case

* Polishing up

* Fix CI Doc error for quantum chemistry gates

* restoring LaTeX rendering

* polishing up

---------

Co-authored-by: Fe-r-oz <ferozahmad7cf@gmail.com>
@kshyatt-aws kshyatt-aws requested a review from a team as a code owner October 9, 2024 18:50
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (2de28b3) to head (06429b3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   98.89%   98.91%   +0.01%     
==========================================
  Files          23       23              
  Lines        3453     3495      +42     
==========================================
+ Hits         3415     3457      +42     
  Misses         38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kshyatt-aws kshyatt-aws merged commit c813a10 into main Oct 11, 2024
17 checks passed
@kshyatt-aws kshyatt-aws deleted the qchem branch October 11, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants